-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Back to downloading of jars #42
Conversation
Nice Vitor! I think it is really good that way -- I like the minimal dependency introduced, as well that it's now downloaded from our repo. Feel free to merge:) |
Just an afterthought: I think it would be nice when the JARs are downloaded to display to the user the information like
This way the user will understand where the initial delay comes from. |
May I suggest embedding the SHA-256 hashes of each JAR file in the Rust code, and checking them after the download to ensure they were not corrupted or tempered with during transfer. |
that is a very good idea! |
|
It does prevent against tampering during transfer but not corruption when writing to disk for example. I would therefore still advise checking the hash to ensure the file that's been downloaded and written to disk is intact. |
That makes sense, thanks! Done in 4b27208. I'll update the top-level comment accordingly. |
Done in 7562461. |
c03f13e
to
d759e4b
Compare
Looks good to me:) |
Closes: #41
This PR essentially reverts #25. Differences:
ureq
insteadreqwest
asureq
is more lightweightmodelator
not working